fix(opencode): add trailing newline to help output#30547
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate PRs found:
These PRs all address the exact same issue: adding a trailing newline to the help output to ensure the shell prompt appears on a new line. You should check the status of these existing PRs (merged, closed, or still open) before proceeding with PR #30547. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
59bf1cb to
520a9f2
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts CLI stderr output formatting to always end messages with a newline.
Changes:
- Append
EOLto non-opencodeoutput written to stderr. - Append
EOLto normalopencodeoutput written to stderr.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
C'mon guys. These are fairly simple fixes that can be merged. Others can be closed as duplicates. Just annoying that prompt gets stuck at some other column than 0, unnecessary wrapping occurs.
|
520a9f2 to
c339040
Compare
Issue for this PR
Type of change
What does this PR do?
The
--helpoutput does not end with a newline. When used Zsh, this was not an issue as the shell prompt detects this and adds the newline automatically. But when used in a simple Bash shell, the subsequent prompt appears at the end of the last line.How did you verify your code works?
bun install && bun run dev -- --help-> validated prompt appears on a newlinebun install && bun run dev -- --unknown-param-> validated prompt appears on a newlineScreenshots / recordings
N/A, see excerpts below;
Before
After
Checklist