Skip to content

fix(desktop): ensure Electron binary before predev via install.js#26202

Open
JackLuguibin wants to merge 1 commit into
anomalyco:devfrom
JackLuguibin:fix/desktop-predev-electron-postinstall
Open

fix(desktop): ensure Electron binary before predev via install.js#26202
JackLuguibin wants to merge 1 commit into
anomalyco:devfrom
JackLuguibin:fix/desktop-predev-electron-postinstall

Conversation

@JackLuguibin
Copy link
Copy Markdown

@JackLuguibin JackLuguibin commented May 7, 2026

Issue for this PR

Closes #26204

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Before predev runs, we check whether the Electron OS binary was downloaded by looking for path.txt under packages/desktop/node_modules/electron (that file is created after a successful install.js / postinstall). If it is missing—e.g. fresh clone, installs with scripts skipped, or a broken partial install—we run node install.js in that directory to fetch the platform binary, then continue with the existing copy-icons and build-node steps. That way predev fails less often with “no Electron binary” errors buried in later commands.

How did you verify your code works?

Remove or temporarily delete node_modules/electron/path.txt under packages/desktop, run whatever invokes predev, and confirm the script logs the missing-binary message, runs install.js, recreates path.txt, and completes the rest of predev. On a machine where Electron is already installed correctly, confirm the install path is skipped because path.txt exists.

Screenshots / recordings

N/A (not a UI change).

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@JackLuguibin JackLuguibin requested a review from adamdotdevin as a code owner May 7, 2026 15:35
@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions github-actions Bot mentioned this pull request May 18, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop predev should ensure Electron OS binary exists

1 participant