fix: increase LSP initialize timeout for JDTLS and KotlinLS#25648
Closed
norbu35 wants to merge 1 commit into
Closed
fix: increase LSP initialize timeout for JDTLS and KotlinLS#25648norbu35 wants to merge 1 commit into
norbu35 wants to merge 1 commit into
Conversation
JDTLS (Eclipse JDT Language Server) and KotlinLS are JVM-based language servers that must perform Gradle project sync and workspace indexing during LSP initialize. For real-world projects this routinely takes 60-180 seconds, well above the default 45 s timeout. Add an optional initializeTimeout field to the LSP server Handle interface so built-in servers can declare their timeout needs. Use it in the client with the existing 45 s constant as the default. Set 180 s for JDTLS and KotlinLS, both of which run on the JVM and trigger Gradle sync during initialization. Closes anomalyco#23982
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Author
|
Closing in favor of reopened #23988 with updated description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JDTLS and KotlinLS are JVM-based language servers that perform Gradle sync and workspace indexing during the LSP
initializehandshake. For real projects this takes 60–180 seconds, well above the default 45 s timeout — causinglsp_diagnosticsto fail withLSP request timeout (method: initialize).See #23982 for full diagnosis and logs.
Changes
initializeTimeoutfield toLSPServer.Handleso built-in servers can declare their timeout needsclient.tswith the existingINITIALIZE_TIMEOUT_MS(45 s) as the default — no behavior change for any other serverinitializeTimeout: 180_000for JDTLS and KotlinLSTesting
Closes #23982