Skip to content

fix: invert *_ready getters to fix server status indicator#25077

Merged
Brendonovich merged 1 commit into
devfrom
fix-server-status-grey
Apr 30, 2026
Merged

fix: invert *_ready getters to fix server status indicator#25077
Brendonovich merged 1 commit into
devfrom
fix-server-status-grey

Conversation

@Brendonovich
Copy link
Copy Markdown
Member

Summary

The server status indicator dot in the top bar was always grey instead of green because the *_ready getters (mcp_ready, provider_ready, lsp_ready) in child-store.ts were returning query.isLoading instead of !query.isLoading.

Since TanStack Query's isLoading is true during fetching and false once data is available, these getters were semantically inverted — "ready" was true only while loading and false after data arrived.

Changes

  • Invert provider_ready, mcp_ready, and lsp_ready getters to return !query.isLoading

@Brendonovich Brendonovich merged commit 908e281 into dev Apr 30, 2026
11 checks passed
@Brendonovich Brendonovich deleted the fix-server-status-grey branch April 30, 2026 07:10
Eric-Guo added a commit to Eric-Guo/opencode that referenced this pull request May 1, 2026
@Eric-Guo
Copy link
Copy Markdown
Contributor

Eric-Guo commented May 1, 2026

This PR break model selecting box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants