fix: invert *_ready getters to fix server status indicator#25077
Merged
Conversation
Eric-Guo
added a commit
to Eric-Guo/opencode
that referenced
this pull request
May 1, 2026
…nomalyco#25077)" This reverts commit 908e281.
Contributor
|
This PR break model selecting box |
6 tasks
66 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server status indicator dot in the top bar was always grey instead of green because the
*_readygetters (mcp_ready,provider_ready,lsp_ready) inchild-store.tswere returningquery.isLoadinginstead of!query.isLoading.Since TanStack Query's
isLoadingistrueduring fetching andfalseonce data is available, these getters were semantically inverted — "ready" wastrueonly while loading andfalseafter data arrived.Changes
provider_ready,mcp_ready, andlsp_readygetters to return!query.isLoading