chore: rm broken codesearch tool#24992
Merged
Merged
Conversation
Collaborator
Author
|
/review |
Contributor
|
lgtm |
oleksii-honchar
pushed a commit
to oleksii-honchar/better-opencode
that referenced
this pull request
Apr 29, 2026
sdeonvacation
pushed a commit
to sdeonvacation/opencode-x
that referenced
this pull request
Apr 30, 2026
This was referenced May 6, 2026
Astro-Han
added a commit
to Astro-Han/pawwork
that referenced
this pull request
May 8, 2026
Remove the broken upstream `codesearch` tool from PawWork as the PR 3a follow-up for #477. Root cause: - Upstream opencode removed this tool in anomalyco/opencode#24992 because Exa MCP no longer exposes `get_code_context_exa`. - PawWork still had the stale tool registered after PR #504 intentionally split it out from the broader runtime safety slice. - Leaving it exposed meant the model could still call a tool that fails at runtime. Scope included: - Deleted `packages/opencode/src/tool/codesearch.ts` and `codesearch.txt`. - Removed registry initialization, builtin exposure, provider gating, default explore-agent permission, CLI rendering, and permission schema fields. - Removed stale SDK/OpenAPI permission schema entries. - Removed app settings labels and UI/i18n dedicated rendering for `codesearch`, so historical unknown parts fall back to generic rendering. - Removed the stale Effect migration checklist entry so future sync work does not try to migrate a deleted tool. - Added a registry regression test proving the built-in tool list no longer contains `codesearch`. Explicitly out of scope: - Web search behavior and Exa web-search quota/auth flows. - Desktop/app manual ports planned for the next #477 slice. - Effect foundation, effectCmd, HttpApi/listener migration, generated SDK regeneration beyond the removed field, dependencies, lockfile, CI/workflow, and packaging changes. Verification: - `bun install --frozen-lockfile` in the fresh worktree with no lockfile changes. - Red test confirmed the new registry assertion failed while production still exposed `codesearch`. - `bun --cwd packages/opencode test test/tool/registry.test.ts` -> 19 passed. - Residual scan showed only negative registry-test assertions mention `codesearch`. - `bun run --cwd packages/opencode typecheck` -> passed. - `bun run --cwd packages/ui typecheck` -> passed. - `bun run --cwd packages/app typecheck` -> passed. - `git diff --check` -> passed. - `packages/sdk/openapi.json` parsed successfully. - PR CI/status checks were green before merge, including ci, typecheck, unit-app, unit-desktop, unit-opencode, desktop-smoke, e2e-artifacts, CodeQL, dependency-review, commit-lint, PR title lint, action-semantic-pull-request, and CodeRabbit. - Review thread check returned no unresolved threads. Follow-up: - #477 remains open. The next sync work should move to the consolidated desktop/app manual-port slice unless a newer live upstream/PR scan shows an already-open PR covering it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #23932
Closes: #21292