fix(desktop-electron): avoid startup loading hang#23307
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Found 1 potential related PR: PR #19281: fix(desktop): add timeout guards to prevent Windows startup hang This PR addresses a similar issue - a desktop startup hang, though on Windows instead of macOS. Both PRs are fixing platform-specific startup loading hangs in the Electron desktop app and likely involve similar root causes or complementary fixes. Note: This is a different PR (not a duplicate of #23307), but addresses the same general problem space. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #23308
Type of change
What does this PR do?
This fixes an Electron desktop startup hang on macOS where the app can stay on
Just a moment...even after the sidecar is ready.The change does two things:
init-steplistener alive until the loading flow reachesdoneHow did you verify your code works?
I built the patched Electron desktop app locally on macOS arm64 and launched it with a clean local state. Before the change it stayed on the loading window. After the change it opened into the app successfully.
Screenshots / recordings
UI loading fix only. No screenshot attached.
Checklist