Skip to content

fix(desktop-electron): avoid startup loading hang#23307

Closed
aiulms wants to merge 2 commits into
anomalyco:devfrom
aiulms:fix/desktop-loading-hang
Closed

fix(desktop-electron): avoid startup loading hang#23307
aiulms wants to merge 2 commits into
anomalyco:devfrom
aiulms:fix/desktop-loading-hang

Conversation

@aiulms
Copy link
Copy Markdown

@aiulms aiulms commented Apr 18, 2026

Issue for this PR

Closes #23308

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This fixes an Electron desktop startup hang on macOS where the app can stay on Just a moment... even after the sidecar is ready.

The change does two things:

  • keeps the preload init-step listener alive until the loading flow reaches done
  • removes a startup wait in the Electron path that can block on sqlite migration state that is not resolved on this path

How did you verify your code works?

I built the patched Electron desktop app locally on macOS arm64 and launched it with a clean local state. Before the change it stayed on the loading window. After the change it opened into the app successfully.

Screenshots / recordings

UI loading fix only. No screenshot attached.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:issue needs:compliance This means the issue will auto-close after 2 hours. labels Apr 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Found 1 potential related PR:

PR #19281: fix(desktop): add timeout guards to prevent Windows startup hang
#19281

This PR addresses a similar issue - a desktop startup hang, though on Windows instead of macOS. Both PRs are fixing platform-specific startup loading hangs in the Electron desktop app and likely involve similar root causes or complementary fixes. Note: This is a different PR (not a duplicate of #23307), but addresses the same general problem space.

@github-actions github-actions Bot removed needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Apr 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions
Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop Electron can stay stuck on "Just a moment..." after sidecar is ready

1 participant