Skip to content

fix(ui): use parentID matching instead of positional scan for assistant messages #23093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brendonovich merged 1 commit into from
Apr 20, 2026
+2 −4
Merged

fix(ui): use parentID matching instead of positional scan for assistant messages #23093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/ui/src/components/session-turn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,14 +267,12 @@ export function SessionTurn(
if (!msg) return emptyAssistant

const messages = allMessages() ?? emptyMessages
const index = messageIndex()
if (index < 0) return emptyAssistant
if (messageIndex() < 0) return emptyAssistant

const result: AssistantMessage[] = []
for (let i = index + 1; i < messages.length; i++) {
for (let i = 0; i < messages.length; i++) {
const item = messages[i]
if (!item) continue
if (item.role === "user") break
if (item.role === "assistant" && item.parentID === msg.id) result.push(item as AssistantMessage)
}
return result
Expand Down
Loading