Skip to content

fix(app): Shift+Enter newline not working on Windows with IME active #21143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChoiDongHee wants to merge 1 commit into from
Closed

fix(app): Shift+Enter newline not working on Windows with IME active #21143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/app/src/components/prompt-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,8 +1191,10 @@ export const PromptInput: Component<PromptInputProps> = (props) => {
}

// Handle Shift+Enter BEFORE IME check - Shift+Enter is never used for IME input
// and should always insert a newline regardless of composition state
if (event.key === "Enter" && event.shiftKey) {
// and should always insert a newline regardless of composition state.
// On Windows, IME may report event.key as "Process" instead of "Enter" during
// composition, so we also check event.code which reflects the physical key.
if ((event.key === "Enter" || event.code === "Enter") && event.shiftKey) {
addPart({ type: "text", content: "\n", start: 0, end: 0 })
event.preventDefault()
return
Expand Down
Loading