Skip to content

fix(write): enforce explicit file mode despite umask #19077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SeashoreShi wants to merge 3 commits into from
Closed

fix(write): enforce explicit file mode despite umask #19077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dccdb85
fix(write): enforce explicit file mode despite umask
Mar 25, 2026
b4f4bc3
Merge upstream/dev into fix/write-permissions-umask
Mar 31, 2026
1abb0e8
chore(ci): retrigger checks for PR #19077
Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/opencode/src/tool/write.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import DESCRIPTION from "./write.txt"
import { Bus } from "../bus"
import { File } from "../file"
import { FileWatcher } from "../file/watcher"
import { Format } from "../format"
import { FileTime } from "../file/time"
import { Filesystem } from "../util/filesystem"
import { Instance } from "../project/instance"
Expand Down Expand Up @@ -42,9 +41,10 @@ export const WriteTool = Tool.define("write", {
},
})

await Filesystem.write(filepath, params.content)
await Format.file(filepath)
Bus.publish(File.Event.Edited, { file: filepath })
await Filesystem.write(filepath, params.content, 0o644)
await Bus.publish(File.Event.Edited, {
file: filepath,
})
await Bus.publish(FileWatcher.Event.Updated, {
file: filepath,
event: exists ? "change" : "add",
Expand Down
4 changes: 4 additions & 0 deletions packages/opencode/src/util/filesystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ export namespace Filesystem {
try {
if (mode) {
await writeFile(p, content, { mode })
// writeFile mode is still filtered by process umask for newly created files,
// and won't update mode for existing files. Force the requested mode explicitly.
await chmod(p, mode)
} else {
await writeFile(p, content)
}
Expand All @@ -70,6 +73,7 @@ export namespace Filesystem {
await mkdir(dirname(p), { recursive: true })
if (mode) {
await writeFile(p, content, { mode })
await chmod(p, mode)
} else {
await writeFile(p, content)
}
Expand Down
Loading