fix(tui): surface sub-agent provider errors in parent task flow#18444
fix(tui): surface sub-agent provider errors in parent task flow#18444LucasSantana-Dev wants to merge 1 commit into
Conversation
|
The following comment was made by an LLM, it may be inaccurate: I found some potentially related PRs: Related PRs:
Why they're related: These PRs all deal with error handling and propagation from sub-agents/subagents to parent tasks/sessions. PR #18444 specifically focuses on surfacing terminal provider/API errors from |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Any update on this? |
c02dce6 to
ffa2bff
Compare
|
Rebased on upstream/dev (HEAD: ffa2bff). CI re-running. |
|
Already on upstream/dev. HEAD: ffa2bff |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #17583
Type of change
What does this PR do?
This ensures sub-agent provider failures are visible in the parent task flow. The
tasktool previously returned normally even when the sub-agent ended with an assistant API error, which made the parent flow appear successful with no clear failure signal.Now the task tool surfaces non-abort sub-agent assistant errors as tool failures (
Sub-agent failed: ...). This makes rate-limit/provider failures visible in the primary flow instead of being silently swallowed.How did you verify your code works?
cd packages/opencode && bun test test/tool/task.test.tscd packages/opencode && bun run typecheckScreenshots / recordings
Not a UI layout change. TUI behavior change validated by test coverage.
Checklist
Related: #5204