fix(opencode): collect nested subagent sessions in TUI sidebar#15820
Closed
StressTestor wants to merge 2 commits into
Closed
fix(opencode): collect nested subagent sessions in TUI sidebar#15820StressTestor wants to merge 2 commits into
StressTestor wants to merge 2 commits into
Conversation
children() only looked one level deep — subagents spawning subagents were invisible because their parentID pointed to the intermediate session, not the root. Walk up to root and BFS-collect all descendants. Fixes anomalyco#4422
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6 tasks
Collaborator
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #4422
Type of change
What does this PR do?
children()insession/index.tsxonly collected direct children of the root session. when a subagent spawns another subagent, the nested one'sparentIDpoints to the intermediate session, not the root. so it never showed up in the sidebar or keyboard navigation.fix: added a
root()memo that walks up the parent chain, thenchildren()builds a parent->children index and BFS-collects all descendants from the root. single file change, no behavior change for non-nested cases.How did you verify your code works?
bun turbo typecheckpasses (all 16 packages)children()(permissions, questions, sidebar visibility, keyboard nav) to confirm they handle the expanded list correctlyScreenshots / recordings
Not a UI change - logic fix only.
Checklist