Escape key doesn't dismiss dialogs after opening via click on selectable text

[altendky]

Description

Pressing Escape to close a dialog (Message Actions, command palette, etc.) doesn't work when the dialog was opened by clicking on selectable text. Clicking on the dialog or typing a character first makes Escape work again.

Root cause

PR #13315 added a selection guard to the dialog escape handler:

opencode/packages/opencode/src/cli/cmd/tui/ui/dialog.tsx

Line 73 in a8f2884

if ((evt.name === "escape" || (evt.ctrl && evt.name === "c")) && renderer.getSelection()) return

When clicking on selectable text (e.g. a user message), opentui creates a Selection object on mouseDown even for a simple click with no drag. This empty selection is never cleared because startSelection returns early before the clearSelection path runs. The dialog then opens on mouseUp, but renderer.getSelection() still returns the lingering empty Selection, so Escape is blocked indefinitely.

Fix

Change renderer.getSelection() to renderer.getSelection()?.getSelectedText() so Escape is only blocked when there's actual selected text. This matches the existing pattern used elsewhere in the codebase:

• opencode/packages/opencode/src/cli/cmd/tui/routes/session/index.tsx

  Line 1133 in b749fa9

  if (renderer.getSelection()?.getSelectedText()) return

• opencode/packages/opencode/src/cli/cmd/tui/routes/session/index.tsx

  Line 1672 in b749fa9

  if (renderer.getSelection()?.getSelectedText()) return

• opencode/packages/opencode/src/cli/cmd/tui/routes/session/index.tsx

  Line 1742 in b749fa9

  if (renderer.getSelection()?.getSelectedText()) return

Related issues

• ESC key does not close command palette (Ctrl+P) and other popups (MacOs Version 26.3) #15202 — ESC doesn't close command palette or other popups (same root cause)
• ESC not working for /mcp command #14590 — ESC not working for /mcp command (likely same root cause in the TUI)

Related PRs

• feat: windows selection behavior, manual ctrl+c #13315 — introduced the renderer.getSelection() guard (the source of the regression)
• fix(app): allow Esc to close /mcp picker while searching #14653 / fix(app): close /mcp picker on Esc in search #14789 — attempted fixes for ESC not working for /mcp command #14590, but targeted the web packages/app List component, not dialog.tsx (both closed, not merged)
• fix(tui): handle ESC to return to provider list rather than closing modal #14947 — adds onEscape to provider dialog for back-navigation (different issue)
• fix:solved the copy issue in TUI #14101 — fixes a TUI copy issue (different issue)