Skip to content

Conversation

@jnizet
Copy link
Contributor

@jnizet jnizet commented Nov 22, 2025

This option allows not migrating the toHaveClass assertion, which exists in Vitest in browser mode and thus is best left as is.

fix #31917

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #31917

What is the new behavior?

A new browserMode option allows not migrating the toHaveClass assertion, which exists in Vitest in browser mode and thus is best left as is.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…chematic

This option allows not migrating the `toHaveClass` assertion, which exists in Vitest in browser mode and thus is best left as is.

fix angular#31917
@alan-agius4 alan-agius4 requested a review from clydin November 24, 2025 09:43
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 24, 2025
@clydin clydin added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 24, 2025
@clydin clydin merged commit 36cf3af into angular:main Nov 24, 2025
39 checks passed
@clydin
Copy link
Member

clydin commented Nov 24, 2025

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add option to avoid migrating toHaveClass matcher

3 participants