-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@angular/build): simplify SSL handling for ng serve with SSR
#31722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hybrist
requested changes
Nov 7, 2025
packages/angular/build/src/tools/vite/plugins/ssr-ssl-plugin.ts
Outdated
Show resolved
Hide resolved
hybrist
approved these changes
Nov 7, 2025
This commit simplifies the handling of self-signed SSL certificates for with SSR. Previously, tests and potentially users had to set or configure to bypass certificate validation issues with self-signed certificates. Closes angular#31710
aa8afec to
6a5fdad
Compare
ng serve with SSR
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: @angular/build
merge: fix commit message
When the PR is merged, rewrites/fixups of the commit messages are needed
merge: squash commits
When the PR is merged, a squash and merge should be performed
target: minor
This PR is targeted for the next minor release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies the handling of self-signed SSL certificates for
ng servewith SSR. Previously, tests and potentially users had to setNODE_TLS_REJECT_UNAUTHORIZEDorNODE_EXTRA_CA_CERTSto bypass certificate validation issues with self-signed certificates.Closes #31710