fix(#1875): Support npm linked libraries

[serhiisol]

This PR fixes the problem with linked packages (#1875).

Originally I've used http://webpack.github.io/docs/troubleshooting.html#npm-linked-modules-doesn-t-find-their-dependencies official documentation. But for webpack2 the team has changed also configuration object, which doesn't work like described in the article.

So I've found another release note related to configuration object - https://gist.github.com/sokra/27b24881210b56bbaff7#resolving-options

The most important is Resolving options section.

So we have to change our configuration object from:

module.exports = {
  resolve: { fallback: path.join(__dirname, "node_modules") },
  resolveLoader: { fallback: path.join(__dirname, "node_modules") }
};

to:

module.exports = {
  resolve: { 
    modules: [ path.join(__dirname, "node_modules") ]
  }
};

Closes #1875

[filipesilva]

@TheLarkInn can you review?

[clydin]

The new equivalent of fallback should be the following:

resolve: {
  modules: ['node_modules', path.resolve(projectRoot, 'node_modules')]
}

[clydin]

@filipesilva, this PR replaces the module resolution whereas the webpack recommended config adds a fallback.

[filipesilva]

@clydin, good eye, thanks for the heads-up!

[filipesilva]

Could you use modules: ['node_modules', path.resolve(projectRoot, 'node_modules')] instead to have a fallback?

[filipesilva]

See #2291 (comment) for details.

[mmolhoek]

@filipesilva, @serhiisol: FYI: when I use
modules: ['node_modules', path.resolve(projectRoot, 'node_modules')]
it does not work, while when I use
modules: [ path.join(projectRoot, 'node_modules') ]
it does :)

[clydin]

@mmolhoek, do you have an example?

[serhiisol]

@clydin it has still that trouble

metadata_resolver.js:245Uncaught Error: Unexpected value '[object Object]' imported by the module 'SupportChatModule'

or similar to it,

@mmolhoek try this:

modules: [path.resolve(projectRoot, 'node_modules'), 'node_modules']

[mmolhoek]

@clydin, not needed, @serhiisol gave the right modification

[filipesilva]

@TheLarkInn can you weigh as a webpack core member?

[TheLarkInn]

modules: [ path.join(projectRoot, 'node_modules') ] is correct. Requires absolute path to module directory as described.

[TheLarkInn]

Sync branch with master and LGTM pending CI.

[serhiisol]

Done

[filipesilva]

Waiting for CI but added approval.

[sachanacar]

Hi all,

I'm also having this error but I don't use webpack, instead I use SystemJS and Vagrant. Do you know how I could emulate the fix you mentioned for these instead?

Basically doing this:

resolve: { modules: ['node_modules', path.resolve(projectRoot, 'node_modules')] }

But for people not using Webpack.

Thank you for your help!

[blingwang]

It seems we also need this fix in webpack-build-test file.
#3463

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}