Merged
Conversation
Change-Id: I3bacf40947b2f80543ed28c460d3f7e3c8439681
Change-Id: I4023799cab81108a85bcbc5e989a7c8f0d903f3b
Goooler
reviewed
Feb 15, 2024
| name: Pull Request | ||
|
|
||
| on: | ||
| pull_request: |
Contributor
There was a problem hiding this comment.
This workflow could be run on pushing on main branch for better Gradle caching.
| java-version: 17 | ||
|
|
||
| - name: Setup Gradle | ||
| uses: gradle/gradle-build-action@v3 |
Contributor
There was a problem hiding this comment.
This should be replaced by gradle/actions/setup-gradle@v3, check https://github.com/gradle/gradle-build-action/releases/tag/v3.0.0
Comment on lines
+35
to
+36
| - name: Build App | ||
| run: ./gradlew :app:assembleDebug |
Contributor
There was a problem hiding this comment.
Assemble job could be separated into an individual job with much parallelism.
Contributor
|
Addressing a follow-up to #43. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I3bacf40947b2f80543ed28c460d3f7e3c8439681