yuv2buf for processing ImageReader output#405
Merged
ggfan merged 1 commit intoandroid:mainfrom Aug 5, 2021
Merged
Conversation
Contributor
|
cool. a separate note, if you have not filled the CameraX 1.0 survey yet, may you fill it here: https://forms.gle/DarkBYwWFmDzdtLr8? It would be a good one to Camera(X) team: make sure to state your suggestions! Thanks! |
Contributor
|
Confirmed for the performance gain in Pixel3 devices with images 640x480: about 30% improvement. Performance is import. A couple of things to do, I think:
could you help for them? thx |
Contributor
|
@gordinmitya merging this one now, then I will get help internally to convert it to kotlin then plug it into samples (right now it is in the lib module, not used). thank you for the PR. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, I unintentionally closed #336 and had to close #404 because of google-cla bot. So here is updated version of them.
Part discussion of this code is in issue #277.
Documentation about approach, unit-tests, performance benchmarks + demo application are here https://github.com/gordinmitya/yuv2buf. This code is tested in several apps in production with both: Camera2 output and MediaCodec outputs.
I compared performance of previous and new code on my Mi 9t pro (Snapdragon 855): old 3.5-4.0ms, new 2.6-3.0ms.
Modified CameraActivity.kt was used for comparison.
Will be happy to answer questions, if any!