-
Notifications
You must be signed in to change notification settings - Fork 357
Migrate to nav3 #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dturner
wants to merge
89
commits into
main
Choose a base branch
from
dt/nav3-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate to nav3 #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I132c211a6ac55d62b36b14ed622703a50e0d0605
* Adds CI to base
* Update build_and_local_tests.yml * Update build_and_local_tests.yml * Now make it green * Update build_and_local_tests.yml
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…02 (#6) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update actions/setup-java action to v3 * CI - adds distribution to jdk setup Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jose Alcérreca <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update all dependencies * Don't update kotlin yet Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jose Alcérreca <[email protected]>
* Update all dependencies * Revert kotlin updates Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jose Alcérreca <[email protected]>
* Update all dependencies * Fixes toml file Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jose Alcérreca <[email protected]>
* Update all dependencies * Reverts kotlin updates Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jose Alcérreca <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* [Customizer] removes additional files Change-Id: I0a36d45b9ece4b71074226b2d5c0a1ae9c84a093 * Creates check on CI, this should fail Change-Id: If36bd9908afdf7cd00e360fa574ba604f0a6efe9 * Now this should pass Change-Id: Ia4204651412dc0146ccd70f1884aeb084498799c * Actually no, this should pass Change-Id: I9fa8b3bbd6ab1543b67d43285b6fdc93d98b43a9
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
DAC indexer needs the screenshots H2 to id the screenshot image
Back to K 1.9.21
…159) * Bump Kotlin and KSP versions to 2.0.0 * Remove the androidxComposeCompiler version and its usage in composeOptions. * Add Compose compiler plugin in build.gradle.kts
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update all dependencies * Update compileSdk, minSdk, and targetSdk versions --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jose Alcérreca <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This commit migrates the app from Navigation 2 to Navigation 3, following the newly added `migration-guide.md`. Key changes include: * Replacing `NavHost` with `NavDisplay`. * Introducing `NavigationState` to manage navigation back stacks and `Navigator` to handle navigation events, replacing `NavController`. * Defining routes as type-safe `NavKey` objects. * Moving destination definitions from `NavHost`'s graph builder to an `entryProvider`. * Adding Navigation 3 dependencies and removing the old `navigation-compose` library. * Enabling the Kotlin serialization plugin.
dd543d1 to
a0ef504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.