Fix bug of adding particles in the middle of simulations for PeTar #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks Long! I will run the tests and try to merge this today. |
rieder
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed the issue of add new particles in the middle of simulations for PeTar. In the old version, the changeover radii and search radii are not correctly initialized for new particles added in the middle of simulations. If any binaries are added, they are not integrated by using SDAR method, and thus the binary may not be integrated accurately.
This fix also includes the update of Makefile and download.py. The previous version will download src codes everytime when make is used. Since the download versions are fixed, this is not necessary. In addition, this cause difficulty for recompiling and debugging the codes.
Two more methods set_output_step/get_output_step are added for better printing of debugging info for PeTar.