Replace the AMUSE build system #1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ed11942.
It ended up using a mix of the local one and the system one, and it works fine this way, so no reason to keep the local build.
9d6cf55 to
917c47b
Compare
917c47b to
279a069
Compare
rieder
previously approved these changes
May 23, 2025
Contributor
|
being too curious, would like to try this. but where are the new build instructions ? The README file still has the old looking at CI, it seems it's just ./setup install amuse-framework |
Member
Author
|
Ah, good point, I updated some of the stuff in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, it's been a very long time coming, but the to-do list is looking pretty empty and I guess that means that the new build system is done.
There are some broken codes still that need to be fixed, but those issues are unrelated to the build system. The only other items in #1024 are updating the development documentation and updating the CI. The development documentation looks pretty obsolete and needs a bigger clean-up that would be better to have as a separate issue. The CI is incomplete as-is, and I'd likewise like to do that separately as the next item on my list.
This does not merge cleanly, so I'll go fix that, but I wanted to make the PR at least.
Fixes #1024.