Skip to content

Cleanup ic.molecular_cloud #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rieder merged 9 commits into from
May 30, 2025
Merged

Cleanup ic.molecular_cloud #1093

rieder merged 9 commits into from
May 30, 2025

Conversation

@rieder
Copy link
Member

@rieder rieder commented Nov 26, 2024

  • Slightly better syntax
  • More consistent keyword naming, with a warning for when the old style is used
  • No more default number of particles, must be set explicitly

@rieder rieder requested a review from a team as a code owner November 26, 2024 12:54
@rieder rieder requested a review from LourensVeen December 3, 2024 16:01
@stale
Copy link

stale bot commented Feb 4, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale Issues that have been around for a while without updates label Feb 4, 2025
@stale stale bot removed the status: stale Issues that have been around for a while without updates label Feb 4, 2025
@rieder
Copy link
Member Author

rieder commented Feb 4, 2025

Can be merged I think

@stale
Copy link

stale bot commented Apr 29, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale Issues that have been around for a while without updates label Apr 29, 2025
@rieder
Copy link
Member Author

rieder commented May 11, 2025

@LourensVeen could you approve this? I'd like it merged to have more consistency in the book examples.

@stale stale bot removed the status: stale Issues that have been around for a while without updates label May 11, 2025
@rieder rieder mentioned this pull request May 11, 2025
Merged
@rieder
Copy link
Member Author

rieder commented May 29, 2025

@LourensVeen please approve if you have no objections :)

LourensVeen
LourensVeen approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@LourensVeen LourensVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rieder rieder merged commit 8d81c91 into amusecode:main May 30, 2025
3 of 4 checks passed
@rieder rieder deleted the cleanup/ic_molecular_cloud branch June 10, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LourensVeen LourensVeen LourensVeen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rieder @LourensVeen