Datapack Control Animations by duzos · Pull Request #1974 · amblelabs/ait

duzos · 2026-01-24T21:23:27Z

closes #1953

…nt size

fix: increment control

perf: cache console in generator

…ate schema usage

Copilot

Pull request overview

This pull request adds per-control animations for datapack consoles, allowing console controls to have customizable animations that reflect their state. The implementation introduces a new Transformations utility class, updates the control system to support animation references, and modifies rendering logic to apply per-control animations.

Changes:

Added animation support to ControlTypes allowing datapack consoles to define control-specific animations
Implemented getTargetProgress method across all control classes to determine animation state
Created Transformations record to consolidate scale, offset, and rotation transformations

Reviewed changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
tardim.geo.json	New Bedrock geometry file for a TARDIS model
Transformations.java	New utility class for managing model transformations (offset, scale, rotation)
ControlTypes.java	Added animation reference field and updated constructor to support per-control animations
Control.java	Added getTargetProgress method to determine animation progress based on control state
ControlRegistry.java	Added fallback method to return a default control when lookup fails
ConsoleControlEntity.java	Integrated animation state tracking and client/server synchronization for control animations
DatapackConsole.java	Updated to use Transformations class and support animation inheritance from parent consoles
ClientConsoleVariantRegistry.java	Enhanced texture/emission/model fallback logic with predicate-based parent lookup
ConsoleVariantRegistry.java	Updated syncing to use Transformations and added null safety check for parent()
BedrockConsoleModel.java	Implemented control animation application with caching and integration with console rendering
ConsoleBlockEntity.java	Added client-side control entity caching with periodic refresh for animation rendering
ConsoleRenderer.java	Changed render layer from EntityCutout to EntityTranslucentCull
ConsoleGeneratorRenderer.java	Added model caching and reordered transformation application
BedrockExteriorModel.java	Removed non-looping animation check that was logging errors
All Control implementations	Implemented getTargetProgress to expose control state for animations
IncrementControl.java, IncrementManager.java	Added methods to support animation progress calculation
PosControl.java	Changed shouldHaveDelay to return true
PowerControl.java	Removed unnecessary cast to ServerPlayerEntity
ControlAnimationState.java	Deleted file (replaced by TargetedAnimationState from amblekit)
gradle.properties	Updated amblekit version to support new animation features

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-03T00:58:31Z

+import net.minecraft.entity.EntityDimensions;
+import net.minecraft.util.Identifier;
+import org.jetbrains.annotations.Nullable;
+import org.joml.Vector3f;


Duplicate imports for EntityDimensions, Identifier, Vector3f, and Optional. These imports appear twice (lines 8/17, 10/18, 6/20, 22/14). Only one import for each is needed.

Suggested change

import net.minecraft.entity.EntityDimensions;

import net.minecraft.util.Identifier;

import org.jetbrains.annotations.Nullable;

import org.joml.Vector3f;

import org.jetbrains.annotations.Nullable;

Copilot · 2026-02-03T00:58:31Z

+		Control control = entity.getControl();
+		if (control == null) return;
+
+		BedrockAnimation anim = this.animationCache.computeIfAbsent(entity.getControl().id(), k -> findAnimationById(entity));


The animationCache uses the control ID as a key, but the lambda findAnimationById is only called once per control ID. If a control entity changes its animation reference, the cache will still return the old animation. Consider using a composite key that includes both the control ID and animation reference ID, or clearing the cache when animations change.

Copilot · 2026-02-03T00:58:32Z

+			if (cachedClientControls == null || this.age % CLIENT_CACHE_REFRESH_INTERVAL == 0) {
+				cachedClientControls = findControlEntitiesInWorld();


The client-side cache refreshes every CLIENT_CACHE_REFRESH_INTERVAL ticks (2400 = 2 minutes). This means control entities that spawn or despawn won't be reflected in animations for up to 2 minutes. Consider reducing this interval or adding a mechanism to invalidate the cache when control entities are added/removed.

Copilot · 2026-02-03T00:58:32Z

+	"minecraft:geometry": [
+		{
+			"description": {
+				"identifier": "geometry.unknown",


The geometry identifier is "geometry.unknown" (line 6). This should be changed to a more descriptive and unique identifier to avoid conflicts with other models and to make debugging easier. Consider using something like "geometry.tardim" or "geometry.ait.tardim".

Copilot · 2026-02-03T00:58:32Z

 		    matrices.translate(-0.5, 1.5, 0.5);
+		    bedrockConsoleModel.applyOffsets(matrices, entity.getConsoleVariant());


The order of translate and applyOffsets was swapped. The translate is now before applyOffsets (line 92 before line 93), whereas in the old code it was after. This could change the visual positioning of the console model. Please verify this reordering is intentional and doesn't break the rendering.

Suggested change

matrices.translate(-0.5, 1.5, 0.5);

bedrockConsoleModel.applyOffsets(matrices, entity.getConsoleVariant());

bedrockConsoleModel.applyOffsets(matrices, entity.getConsoleVariant());

matrices.translate(-0.5, 1.5, 0.5);

Copilot · 2026-02-03T00:58:33Z

+
+	@Environment(EnvType.CLIENT)
+	public void apply(MatrixStack stack) {
+		stack.translate(offset.x, offset.y * -1, offset.z);


The apply method performs offset.y * -1 (line 33), but this inversion is inconsistent with how offset.x and offset.z are handled. This might be intentional for coordinate system conversion, but should be documented in a comment to explain why Y is inverted.

duzos · 2026-02-03T01:00:19Z

loser review comments

drtheodor · 2026-02-04T19:16:02Z


+	private static final int CLIENT_CACHE_REFRESH_INTERVAL = 2400; // Lazy refresh
+	// Client-side cache for control entities
+	private List<ConsoleControlEntity> cachedClientControls = null;


do you even need this on the client?

yes so the renderer can update the consoles controls

and why does it need that

arent control animations part of the console model
since the control entities arejust pretty much fancy hitboxes?

it needs it because the control entities hold the control data

drtheodor · 2026-02-21T17:09:19Z


+	private static final int CLIENT_CACHE_REFRESH_INTERVAL = 2400; // Lazy refresh
+	// Client-side cache for control entities
+	private List<ConsoleControlEntity> cachedClientControls = null;


and why does it need that

drtheodor · 2026-02-21T17:10:04Z


+	private static final int CLIENT_CACHE_REFRESH_INTERVAL = 2400; // Lazy refresh
+	// Client-side cache for control entities
+	private List<ConsoleControlEntity> cachedClientControls = null;


arent control animations part of the console model
since the control entities arejust pretty much fancy hitboxes?

…oleModel.java Co-authored-by: Theo <git@theo.is-a.dev>

Loqor · 2026-03-05T02:01:03Z

Old and also AI generated. Either finish or merge into the Redux assets PR.

duzos · 2026-03-08T14:07:43Z

not old
not ai generated (just ai reviewed)
finished!!!

duzos added 2 commits January 24, 2026 20:49

api: console control datapack animations

24554a2

closes #1953

api: progress vals for all controls

6c85c33

duzos self-assigned this Jan 24, 2026

github-actions Bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. A: Tardis Components Area: Tardis components & manager. A: Console Area: Tardis console. labels Jan 24, 2026

duzos added 2 commits January 24, 2026 21:35

fix: anim length not being set

5617082

api: fx support

ea346db

duzos added 9 commits January 24, 2026 21:57

fix: TargetedAnimationState extends AnimationState

10b05ce

api: add progress calculation for IncrementControl and expose increme…

4930824

…nt size

build(modkit): use performance branch

bedb2a4

fix: increment control

fix: consoles causing black screen

909bf08

perf: cache console in generator

fix: apply translation before scaling in generator

175b727

api: unify console transformations with Transformations class and upd…

38e4f87

…ate schema usage

fix: datapack consoles now peek at their siblings to find missing values

6934321

upload tardim.geo.json

a6f52c6

wrong model lol

0464877

duzos marked this pull request as ready for review February 1, 2026 23:35

duzos requested review from a team as code owners February 1, 2026 23:35

github-actions Bot added the S: Needs Review Status: Requires additional reviews before being fully accepted. label Feb 1, 2026

duzos requested a review from Copilot February 3, 2026 00:53

Copilot started reviewing on behalf of duzos February 3, 2026 00:54 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

drtheodor requested changes Feb 3, 2026

View reviewed changes

Comment thread src/main/java/dev/amble/ait/registry/impl/console/variant/ClientConsoleVariantRegistry.java

Comment thread src/main/java/dev/amble/ait/data/datapack/DatapackConsole.java Outdated

review changes

838c8ec

duzos requested a review from drtheodor February 4, 2026 19:13

github-actions Bot added the size/M Denotes a PR that changes 100-999 lines. label Feb 4, 2026

drtheodor requested changes Feb 4, 2026

View reviewed changes

review changes

5b172e3

duzos requested a review from drtheodor February 4, 2026 19:27

drtheodor requested changes Feb 21, 2026

View reviewed changes

Update src/main/java/dev/amble/ait/client/models/consoles/BedrockCons…

9860835

…oleModel.java Co-authored-by: Theo <git@theo.is-a.dev>

duzos requested a review from drtheodor February 21, 2026 17:13

		if (cachedClientControls == null \|\| this.age % CLIENT_CACHE_REFRESH_INTERVAL == 0) {
		cachedClientControls = findControlEntitiesInWorld();

		matrices.translate(-0.5, 1.5, 0.5);
		bedrockConsoleModel.applyOffsets(matrices, entity.getConsoleVariant());

Uh oh!

Conversation

duzos commented Jan 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

duzos commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

drtheodor Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

duzos Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

drtheodor Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

drtheodor Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

duzos Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

drtheodor Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

drtheodor Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Loqor commented Mar 5, 2026

Uh oh!

duzos commented Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants