fix: resolve stale Amber Session check runs stuck in_progress#1255
Merged
Gkrumbach07 merged 2 commits intomainfrom Apr 10, 2026
Merged
fix: resolve stale Amber Session check runs stuck in_progress#1255Gkrumbach07 merged 2 commits intomainfrom
Gkrumbach07 merged 2 commits intomainfrom
Conversation
…efinitely The batch-pr-fixer job created in_progress check runs when dispatching sessions but never updated them to completed when the session finished. Healthy PRs were skipped entirely without resolving their stale checks. Closes #1253 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
This fixes the Amber Session check run staying Root cause: The What changed:
🤖 Session |
Contributor
Merge main to resolve conflicts. Previous commit incorrectly deleted the entire amber-issue-handler.yml; this restores it from main and applies the proper fix: - handle-comment: find and update existing in_progress check runs instead of creating duplicates - batch-pr-fixer: add update_check_run() and resolve_stale_checks() helpers, resolve stale checks on healthy/skipped PRs each cycle, poll dispatched sessions (up to 30 min) and update checks on completion Closes #1253 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Resolved merge conflicts with main and applied the proper fix for stale check runs:
The previous session had incorrectly deleted the entire workflow file instead of modifying it — this commit restores it from main and applies the targeted fix. 🤖 Session |
Gkrumbach07
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batch-pr-fixerjob createdin_progresscheck runs when dispatching sessions but never updated them tocompletedwhen the session finished. Healthy PRs were skipped entirely without resolving their stale checks. Additionally, thehandle-commentjob always created new check runs instead of updating existing ones.update_check_run,resolve_stale_checks, andget_existing_check_run_idfunctions to the batch Python scriptin_progresschecks for healthy/skipped PRs on each batch cyclehandle-commentjob, finds and updates existingin_progresschecks via PATCH instead of creating new ones via POSTTest plan
workflow_dispatchand verify stale checks on healthy PRs are completed@ambient-codeon a PR and verify the existing in_progress check is updated (not duplicated)Closes #1253
🤖 Ambient Session