Skip to content

fix: make E2E test timeouts configurable and add sensitive directory test#206

Merged
jeremyeder merged 2 commits intomainfrom
fix/test-reliability
Dec 10, 2025
Merged

fix: make E2E test timeouts configurable and add sensitive directory test#206
jeremyeder merged 2 commits intomainfrom
fix/test-reliability

Conversation

@jeremyeder
Copy link
Copy Markdown
Contributor

Summary

  • Make E2E test timeouts configurable to prevent flaky failures on slower CI runners
  • Add E2E test for sensitive directory blocking (critical security feature)

Changes

  • Add DEFAULT_TIMEOUT environment variable (default: 90s)
  • Replace all hardcoded timeout=60 with DEFAULT_TIMEOUT
  • Add new TestCriticalSecurityFeatures class
  • Add test_assess_blocks_sensitive_directories() E2E test

Benefits

  • Prevents flaky test failures on slower CI runners
  • Allows developers to adjust timeout based on environment
  • Adds end-to-end test coverage for critical security feature
  • Validates sensitive directory prompts work correctly

Configuration

Set AGENTREADY_TEST_TIMEOUT environment variable to override default:

export AGENTREADY_TEST_TIMEOUT=120  # For slower systems
pytest tests/e2e/

Test Plan

  • All linters pass (black, isort, ruff)
  • Pre-commit hooks pass
  • Conventional commit format verified
  • New E2E test for sensitive directories passes (requires /etc directory)

Fixes #192

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test Reliability: Configurable timeouts and sensitive directory E2E test

1 participant