App Crash in settings

[Ahmed-Abd-Elsamie]

The app crashes when changing between light and dark theme

[chirag-jn]

Is this an issue in every phone or is it specific to the manufacturer of your device?

[Ahmed-Abd-Elsamie]

Yes, i tried running the app on multiple devices and it's still crashing

[chirag-jn]

@Ahmed199810 Seems weird. Can you please give the specifications of those devices?

[Ahmed-Abd-Elsamie]

The first is real device (Xiaomi Redmi note 7 Android 9)
The second is emulator Nox with Android 5
@chirag-jn

[chirag-jn]

@Ahmed199810 could you figure out what went wrong?

[Ahmed-Abd-Elsamie]

@chirag-jn I have figured out the problem and fixed it.
the problem was in the NavigationActivity.class , after changing between light and dark theme we finish the activity then start it again from itself. and this will cause the app to crash because we are trying to start it from null context.

Solution :
i removed startActivityForResult function and replaced it with the following:
1 - once opening the settings page i finish the navigationActivity.
2 - once do any change in the settings like changing between light and dark themes, we start the NavigationActivity again from the settingActivity.

I tried this method and solved the problem

here is the the code changes
775486d

[chirag-jn]

PR #440 already handles this issue by changing the method of accessing the context in NavigationFragment. That's another possible fix.