Skip to content

Add cv PDF link to social icons#3240

Merged
george-gca merged 5 commits intoalshedivat:mainfrom
lukasschirren:main
Nov 17, 2025
Merged

Add cv PDF link to social icons#3240
george-gca merged 5 commits intoalshedivat:mainfrom
lukasschirren:main

Conversation

@lukasschirren
Copy link
Copy Markdown
Contributor

@lukasschirren lukasschirren commented Jul 15, 2025

Fixes issue #3243

Add CV PDF link to social icons

  • Added CV icon to social media links section
  • CV appears after LinkedIn icon in the contact section
  • Uses academicons CV symbol for consistent academic styling
  • Links to /assets/pdf/CV_Schirren.pdf and opens in new tab
  • Updated _includes/social.liquid to handle cv_pdf field
  • Updated _data/socials.yml with CV configuration
  • Updated _scripts/search.liquid.js with cv search functionality

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 15, 2025

Deploy Preview for relaxed-lollipop-b6bc17 ready!

Name Link
🔨 Latest commit 2788080
🔍 Latest deploy log https://app.netlify.com/projects/relaxed-lollipop-b6bc17/deploys/687a25d5e750f400084272d0
😎 Deploy Preview https://deploy-preview-3240--relaxed-lollipop-b6bc17.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@george-gca
Copy link
Copy Markdown
Collaborator

This needs to be added to more places. Check our newly added section in CONTRIBUTING.md.

@lukasschirren
Copy link
Copy Markdown
Contributor Author

I updated the PR to refer to the issue. Also updated the _scripts/search.liquid.js file to enable search functionality. Anything else?

Comment thread _data/socials.yml Outdated
@lukasschirren lukasschirren requested a review from george-gca July 25, 2025 09:04
@stale
Copy link
Copy Markdown

stale Bot commented Sep 25, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the wontfix label Sep 25, 2025
@lukasschirren lukasschirren changed the title Add CV PDF link to social icons Add cv PDF link to social icons Sep 25, 2025
@lukasschirren
Copy link
Copy Markdown
Contributor Author

@george-gca Is there anything else I should change?

@george-gca george-gca linked an issue Nov 17, 2025 that may be closed by this pull request
2 tasks
@george-gca george-gca merged commit 33017e7 into alshedivat:main Nov 17, 2025
4 checks passed
@george-gca
Copy link
Copy Markdown
Collaborator

Sorry for the (VERY LONG) delay. Thanks for the PR.

Tzxtoiny pushed a commit to Tzxtoiny/Tzxtoiny.github.io that referenced this pull request Nov 20, 2025
Fixes issue alshedivat#3243 

Add CV PDF link to social icons

- Added CV icon to social media links section
- CV appears after LinkedIn icon in the contact section
- Uses academicons CV symbol for consistent academic styling
- Links to `/assets/pdf/CV_Schirren.pdf` and opens in new tab
- Updated `_includes/social.liquid` to handle `cv_pdf` field
- Updated `_data/socials.yml` with CV configuration
- Updated `_scripts/search.liquid.js` with cv search functionality
ruiwen0615 pushed a commit to ruiwen0615/ruiwen0615.github.io that referenced this pull request Jan 12, 2026
Fixes issue alshedivat#3243 

Add CV PDF link to social icons

- Added CV icon to social media links section
- CV appears after LinkedIn icon in the contact section
- Uses academicons CV symbol for consistent academic styling
- Links to `/assets/pdf/CV_Schirren.pdf` and opens in new tab
- Updated `_includes/social.liquid` to handle `cv_pdf` field
- Updated `_data/socials.yml` with CV configuration
- Updated `_scripts/search.liquid.js` with cv search functionality
vltanh pushed a commit to vltanh/vltanh.github.io that referenced this pull request Apr 28, 2026
Fixes issue alshedivat#3243 

Add CV PDF link to social icons

- Added CV icon to social media links section
- CV appears after LinkedIn icon in the contact section
- Uses academicons CV symbol for consistent academic styling
- Links to `/assets/pdf/CV_Schirren.pdf` and opens in new tab
- Updated `_includes/social.liquid` to handle `cv_pdf` field
- Updated `_data/socials.yml` with CV configuration
- Updated `_scripts/search.liquid.js` with cv search functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CV PDF link to social icons

2 participants