Skip to content

Link homepage virtual classroom to lobby auto-join and fix mobile layout#50

Merged
A1L13N merged 4 commits into
mainfrom
copilot/link-virtual-classroom-homepage
Apr 21, 2026
Merged

Link homepage virtual classroom to lobby auto-join and fix mobile layout#50
A1L13N merged 4 commits into
mainfrom
copilot/link-virtual-classroom-homepage

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 21, 2026

Summary

This PR links the homepage Virtual Classroom CTA to the classroom page and auto-joins the lobby room. It also improves the classroom mobile layout so the canvas, controls, and chat are usable on narrow screens.

Changes

  • Updated homepage Virtual Classroom CTA in /public/index.html to navigate to:
    • /classroom_poc.html?autojoin=1&room=lobby
  • Updated CTA text to reflect behavior:
    • Join Lobby Classroom
  • Added classroom entry parameter handling in /public/classroom_poc.html:
    • Auto-join when autojoin=1
    • Prefill room from room query parameter
    • Prefill display name from name query parameter or stored user profile
  • Added sanitization for room and display-name inputs used by auto-join and join flow
  • Refactored join flow into a reusable joinClassroom() function and used it for both manual and auto join
  • Improved mobile responsiveness for classroom layout:
    • Main content switches to stacked layout on small screens
    • Chat panel becomes full-width with mobile-friendly height
    • Controls bar wraps more cleanly on small viewports

Validation

  • pytest passes locally: 238 passed (existing warnings unchanged)
  • parallel_validation run multiple times
    • CodeQL: no findings for analyzable languages in this change

Notes

  • One recurring review suggestion requested adding role="button" to the homepage anchor CTA. This was not applied because it is a semantic navigation link (<a href=...>) and is already keyboard accessible by default.

@cloudflare-workers-and-pages
Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
learn 4d8c315 Apr 21 2026, 03:35 AM

@A1L13N A1L13N marked this pull request as ready for review April 21, 2026 03:36
Copilot AI requested a review from A1L13N April 21, 2026 03:36
@A1L13N A1L13N merged commit c132da2 into main Apr 21, 2026
2 checks passed
@A1L13N A1L13N deleted the copilot/link-virtual-classroom-homepage branch April 21, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants