Add separate IP based rate limiting for chat domain #2702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment all traffic that comes into the backend load balancer is subject to an IP based rate limiting at the WAF level. This is a problem for chat as we expect all traffic to some from a single source of traffic -the gov.uk app- therefore to solve this issue and add more flexibility in controlling the traffic for chat we add new rules that introduce a separate rate limiting when traffic is going towards the chat domain
44467a1 to
bd06c9c
Compare
Contributor
|
Hi @rtrinque, do you still need a review on this. It's been open for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment all traffic that comes into the backend load balancer is subject to an IP based rate limiting at the WAF level. This is a problem for chat as we expect all traffic to come from a single source of traffic -the gov.uk app- therefore to solve this issue and add more flexibility in controlling the traffic for chat we add new rules that introduce a separate rate limiting when traffic is going towards the chat domain