feat(recommend): add "Looking Similar" model#1469
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5ec2f38:
|
dhayab
left a comment
There was a problem hiding this comment.
My guess regarding failing tests is that they are just really flaky. I looked into merged PRs and all their pipelines are retried a few time until they go green.
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
shortcuts
left a comment
There was a problem hiding this comment.
this looks great :) do you plan on adding it to the generated clients too?
dhayab
left a comment
There was a problem hiding this comment.
Looks good to me 👍.
Regarding the RC release, as this addition follows closely how other methods are defined, I think it can be released directly in a minor as part of the monorepo release process.
If you prefer having an RC/Beta release, you should not merge this branch, and we can instead perform a manual release (or perhaps there's another process owners can guide us through).
|
@shortcuts indeed we should this to the generated clients as well 👍 @dhayab No beta/RC needed, once merged this should probably be simply released under |
cool! let me know if you need help contributing to the specs |
Implement Recommend
looking-similarmodel.Beyond the model name, everything else should work exactly as other recommend models such as related products.