-
Notifications
You must be signed in to change notification settings - Fork 326
Update Docker image tags to use GHCR repo #3013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
66ea386 to
d2bdeb4
Compare
helm/charts/aleph/values.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to update the images in the Helm chart too while I’m at it. This should be the only file that specifies the repos, all templates just reference the values. But I’m not familiar with Helm, so maybe I’m missing something!
d2bdeb4 to
cce31b2
Compare
stchris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me, thanks for this change! I think the only comment I have is that we should update this for the 3.14.x releases and not just for develop and future releases!
So we should merge this into main and create a new 3.14.x release with these changes? |
I think this change should go into Github: comment threads when? |
Our ES image uses only image tags based on commit hashes, trying to pull this image would always fail.
|
@Rosencrantz @stchris As discussed earlier, I have made the following changes:
|
stchris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Closing as all the changes are in main already, I think |
Right now, UI tests build the Docker image twice because the tags do not match, causing CI runs to take 2-3 mins longer than necessary.