Skip to content

Conversation

@tillprochaska
Copy link
Contributor

Right now, UI tests build the Docker image twice because the tags do not match, causing CI runs to take 2-3 mins longer than necessary.

@tillprochaska tillprochaska force-pushed the fix/compose-config-ghcr branch 2 times, most recently from 66ea386 to d2bdeb4 Compare April 26, 2023 15:33
Copy link
Contributor Author

@tillprochaska tillprochaska Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to update the images in the Helm chart too while I’m at it. This should be the only file that specifies the repos, all templates just reference the values. But I’m not familiar with Helm, so maybe I’m missing something!

@tillprochaska tillprochaska marked this pull request as ready for review April 26, 2023 15:38
@tillprochaska tillprochaska force-pushed the fix/compose-config-ghcr branch from d2bdeb4 to cce31b2 Compare April 26, 2023 15:44
Copy link
Contributor

@stchris stchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me, thanks for this change! I think the only comment I have is that we should update this for the 3.14.x releases and not just for develop and future releases!

@tillprochaska
Copy link
Contributor Author

I have is that we should update this for the 3.14.x releases and not just for develop and future releases!

So we should merge this into main and create a new 3.14.x release with these changes?

@stchris
Copy link
Contributor

stchris commented Apr 27, 2023

So we should merge this into main and create a new 3.14.x release with these changes?

I think this change should go into develop and then we should ship it with 3.14.1 (for which there is a release branch available).

Github: comment threads when?

Our ES image uses only image tags based on commit hashes, trying to pull this image would always fail.
@tillprochaska
Copy link
Contributor Author

@Rosencrantz @stchris As discussed earlier, I have made the following changes:

  • Updated all references to outdated Aleph versions (3.12.2) to the latest Aleph version 3.14.0.
  • Adjusted the bump2version configuration to update the Aleph version in Compose files in the contrib/ directory.
  • Fixed the image tag of the ES image in the Keycloak example.

Copy link
Contributor

@stchris stchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tillprochaska
Copy link
Contributor Author

Closing as all the changes are in main already, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants