Skip to content

Fix app banner #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rosencrantz merged 1 commit into from
Jan 20, 2023
Merged

Fix app banner #2826

Rosencrantz merged 1 commit into from
Jan 20, 2023

Conversation

@tillprochaska
Copy link
Contributor

@tillprochaska tillprochaska commented Jan 19, 2023 •
edited
Loading

Close #2824

@tillprochaska tillprochaska force-pushed the till/2842-fix-app-banner branch from 3111144 to 6539e39 Compare January 19, 2023 20:47
@Rosencrantz
Copy link
Contributor

Rosencrantz commented Jan 20, 2023

Nitpick. But if we are trying to follow gitflow processes we need to change from prefixing branches with our usernames to prefixing them with the appropriate convetion. For this fix the branch should have been prefixed like this:

bugfix/2842-fix-app-banner

@Rosencrantz Rosencrantz merged commit 3213159 into develop Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catileptic catileptic Awaiting requested review from catileptic

@stchris stchris Awaiting requested review from stchris

1 more reviewer

@Rosencrantz Rosencrantz Rosencrantz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Aleph
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tillprochaska @Rosencrantz