fix(provider): apply auth loader model cost mutations to live provider#1
Closed
albertdbio wants to merge 1 commit into
Closed
fix(provider): apply auth loader model cost mutations to live provider#1albertdbio wants to merge 1 commit into
albertdbio wants to merge 1 commit into
Conversation
Auth plugins can zero per-model `cost` in their `auth.loader` hook (e.g. subscription auth that hides the cost tracker for flat-fee plans). anomalyco#26550 wrapped the loader's provider argument in `toPublicInfo()` for JSON safety, which made the loader mutate a throwaway deep clone that core then discarded — so subscription users saw per-token costs reappear in the TUI. Copy `model.cost` from the (possibly-mutated) clone back onto the live provider after the loader returns. Only `cost` is copied, preserving the JSON-safety guarantee that functions/symbols never cross the plugin boundary. Built-in Codex/Copilot were unaffected because they use the separate `provider.models` return-value hook, which was never broken. Adds a regression test asserting a loader that zeros a model's cost results in that cost being zero on the resolved provider model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auth plugins can zero per-model
costin theirauth.loaderhook (e.g. subscription auth that hides the cost tracker for flat-fee plans). anomalyco#26550 wrapped the loader's provider argument intoPublicInfo()for JSON safety, which made the loader mutate a throwaway deep clone that core then discarded — so subscription users saw per-token costs reappear in the TUI.Copy
model.costfrom the (possibly-mutated) clone back onto the live provider after the loader returns. Onlycostis copied, preserving the JSON-safety guarantee that functions/symbols never cross the plugin boundary.Built-in Codex/Copilot were unaffected because they use the separate
provider.modelsreturn-value hook, which was never broken.Adds a regression test asserting a loader that zeros a model's cost results in that cost being zero on the resolved provider model.
Issue for this PR
Closes #
Type of change
What does this PR do?
Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.