Modernise ruff configuration#65
Merged
Merged
Conversation
c378218 to
aaf572d
Compare
1b1aadd to
f3f6086
Compare
- Simplify rule selection to core best-practice set - Add target-version templated from min_python_version - Add per-file-ignores for tests - Add isort known-first-party config - Configure format quote-style and indent-style - Remove legacy isort.required-imports and typing-conditional config Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Restore unfixable F401/F841 to protect re-exports and flag unused vars - Remove no-op per-file-ignores (S101, D not in select) - Remove redundant quote-style/indent-style (already defaults) - Restore docstring-code-format Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f3f6086 to
9ba76d5
Compare
- PGH: catches blanket type: ignore and noqa without codes - G: enforces lazy logging format strings - PT: pytest style conventions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
phinate
added a commit
that referenced
this pull request
Mar 20, 2026
* feat: modernise ruff configuration - Simplify rule selection to core best-practice set - Add target-version templated from min_python_version - Add per-file-ignores for tests - Add isort known-first-party config - Configure format quote-style and indent-style - Remove legacy isort.required-imports and typing-conditional config Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: restore unfixable rules and clean up ruff config - Restore unfixable F401/F841 to protect re-exports and flag unused vars - Remove no-op per-file-ignores (S101, D not in select) - Remove redundant quote-style/indent-style (already defaults) - Restore docstring-code-format Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add PGH, G, and PT rule sets to ruff config - PGH: catches blanket type: ignore and noqa without codes - G: enforces lazy logging format strings - PT: pytest style conventions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
phinate
added a commit
that referenced
this pull request
Mar 20, 2026
* feat: modernise ruff configuration - Simplify rule selection to core best-practice set - Add target-version templated from min_python_version - Add per-file-ignores for tests - Add isort known-first-party config - Configure format quote-style and indent-style - Remove legacy isort.required-imports and typing-conditional config * fix: restore unfixable rules and clean up ruff config - Restore unfixable F401/F841 to protect re-exports and flag unused vars - Remove no-op per-file-ignores (S101, D not in select) - Remove redundant quote-style/indent-style (already defaults) - Restore docstring-code-format * feat: add PGH, G, and PT rule sets to ruff config - PGH: catches blanket type: ignore and noqa without codes - G: enforces lazy logging format strings - PT: pytest style conventions --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target-versiontemplated frommin_python_versionS101,D)known-first-partyconfigquote-styleandindent-styleisort.required-imports,unfixable, and typing-conditional configTest plan
uv run ruff check .passes on a freshly generated projectuv run ruff format --check .passesruff checkto failruff check --fixauto-fixes the unused import🤖 Generated with Claude Code