Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
Member
Author
|
each文とfor文にもletありますけど、forはnum型しか入ってこないからいいとして、eachでも分割代入対応したほうがいいですかね |
Member
|
|
This reverts commit f1ecfd8.
salano-ym
approved these changes
Aug 31, 2024
Member
別PRで追加しても良いと思います。jsみたいに仮引数も分割できると便利? |
Member
Author
|
バグ修正は即マージできることに気づいたのでマージします。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
validateKeywordでnull, true, falseがエラーになるように修正
Why
Fix #773
Additional info (optional)
キーワードのテストは #678 (comment) とのことで変えていません。