Merged
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## aiscript-next #415 +/- ##
================================================
Coverage ? 90.41%
================================================
Files ? 25
Lines ? 5154
Branches ? 948
================================================
Hits ? 4660
Misses ? 484
Partials ? 10 ☔ View full report in Codecov by Sentry. |
Contributor
|
これってエラー位置が正しく出るとかって大体は確認できてますか |
Member
Author
|
ざっとは確認しましたが、せっかくなのでいくつかテストを追加しましょうか |
Contributor
|
確認済みならテストはどちらでも大丈夫そうです |
Collaborator
|
👍🏻 👍🏻 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ランタイムエラーをインターセプトし位置情報を付加するようにします。
また、名前空間エラーはコンストラクタで位置情報を受け取るようにします。
関連 #144
Additional info (optional)
VFnの構造が変わっているのは試行錯誤中の副産物です。（結果的にこちらの方がよいと思ったので残しました）