Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## aiscript-next #413 +/- ##
================================================
Coverage ? 90.44%
================================================
Files ? 25
Lines ? 5136
Branches ? 943
================================================
Hits ? 4645
Misses ? 481
Partials ? 10 ☔ View full report in Codecov by Sentry. |
Collaborator
|
👍👍👍 |
Member
|
@marihachi 今気づいたんですが、locのインデックスが1始まりになっているっぽいです。0始まりに修正お願いします。 |
Contributor
Author
|
locはインデックスではないです |
Member
|
|
Contributor
Author
|
ソースコード上の位置はコードエディタなどで行1,列1から始まってますよね |
Collaborator
|
内部的な表現としては0始まりで持っておいて人間への表示時は+1するというのも考えられる |
Contributor
Author
|
パーサー内部では行も列も0始まりで扱ってるのでどちらにも出来ますけど |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
ただ行と列の番号で演算をすることはなさそうな？ |
Contributor
Author
|
ちょっと他のツールとか調査しますか |
Contributor
Author
|
0始まりが好きな人も1始まりが好きな人もいるようなので、どちらが優れているというわけではなさそうです。 |
Collaborator
|
1で |
Member
了解です |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
関連 #144
Why
Additional info (optional)