Add package keyword to list of declaration categories
#232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
I am fine merging this now since the proposal is accepted. Since the feature is additive in Swift 5.9, having his rule in the style guide now won't be problematic for anyone IMHO. |
bachand
approved these changes
Jul 6, 2023
| * `// MARK: Lifecycle` for `init` and `deinit` methods. | ||
| * `// MARK: Open` for `open` properties and methods. | ||
| * `// MARK: Public` for `public` properties and methods. | ||
| * `// MARK: Package` for `package` properties and methods. |
Contributor
There was a problem hiding this comment.
This ordering makes sense to me, based on this description from the proposal.
Member
Author
|
@bachand I updated the SwiftFormat rule in nicklockwood/SwiftFormat#1479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Swift 5.9 adds support for
package-level declarations (SE-0386). We should mention this in the rule discussing how to organize declarations.Should we merge this now or wait until Swift 5.9 is released? Either seems ok to me