Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 5, 2025

Bumps pycares from 4.7.0 to 4.8.0.

Commits
  • 6405d1f Set version to 4.8.0
  • a563896 Add ARES_FLAG_NO_DFLT_SVR and ARES_FLAG_EDNS to API
  • da561b2 Update bundled c-ares to v1.34.5 (#221)
  • 129c07c Cancel previous CI jobs on pull request update
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [pycares](https://github.com/saghul/pycares) from 4.7.0 to 4.8.0.
- [Release notes](https://github.com/saghul/pycares/releases)
- [Changelog](https://github.com/saghul/pycares/blob/master/ChangeLog)
- [Commits](saghul/pycares@v4.7.0...v4.8.0)

---
updated-dependencies:
- dependency-name: pycares
  dependency-version: 4.8.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels May 5, 2025
@github-actions github-actions bot enabled auto-merge (squash) May 5, 2025 08:10
@bdraco
Copy link
Member

bdraco commented May 5, 2025

I was hoping 4.8.0 would make test_query_txt less flakey on MacOS but considering I can't repro it locally on my Mac it might be a GitHub env issue.

I'll re-run it again and it will likely pass on the 2nd or 3rd try.

Edit: I wonder if its somehow being rate limited

@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (dd81a93) to head (addcfb5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files           3        3           
  Lines         311      311           
  Branches       24       24           
=======================================
  Hits          288      288           
  Misses         12       12           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot merged commit 928b8a6 into master May 5, 2025
125 of 157 checks passed
@github-actions github-actions bot deleted the dependabot/pip/pycares-4.8.0 branch May 5, 2025 09:22
@Dreamsorcerer
Copy link
Member

I was hoping 4.8.0 would make test_query_txt less flakey on MacOS but considering I can't repro it locally on my Mac it might be a GitHub env issue.

They're contacting actual live DNS servers, right? So any networking issues would break the tests. Ideally, we'd create a local test DNS server for the tests, but not sure anybody is going to volunteer to implement that.

@bdraco bdraco mentioned this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants