Log-injection improvements #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knewbury01
reviewed
Feb 15, 2024
Contributor
knewbury01
left a comment
There was a problem hiding this comment.
@mbaluda nice work! just a few small comments/questions at this point
|
|
||
| const LOG = cds.log("nodejs"); | ||
| LOG.info("test" + book); | ||
| LOG.info("test" + book); // Log injection alert |
Check failure
Code scanning / CodeQL
Uncontrolled data in logging call
| this.on('format', (req) => { | ||
| const cds2 = require ('@sap/cds/lib') | ||
| const LOG = cds2.log('cds.log') | ||
| const $ = req.data; LOG.info('format:', $) // Log injection alert |
Check failure
Code scanning / CodeQL
Uncontrolled data in logging call
knewbury01
requested changes
Feb 27, 2024
Contributor
knewbury01
left a comment
There was a problem hiding this comment.
only one very tiny change! other than that looks great! @mbaluda
Co-authored-by: Kristen Newbury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beforeandafter.SAP-samples/cloud-cap-samples.