Fix FN cap sources #109
Merged
Fix FN cap sources #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaluda
reviewed
Apr 10, 2024
javascript/frameworks/cap/test/models/cds/remoteflowsources/remoteflowsource.cds.json
Outdated
Show resolved
Hide resolved
mbaluda
reviewed
Apr 10, 2024
| * ``` | ||
| * parameters named `req` are captured in the above example. | ||
| */ | ||
| class ServiceinCDSHandlerParameter extends RemoteFlowSource { |
Contributor
There was a problem hiding this comment.
Could this make use HandlerRegistration in CDS.qll ? Or is this exactly what you wanted to avoid?
Contributor
Author
There was a problem hiding this comment.
technically that part could work, but yeah,
then we would still need to modify the definition of UserDefinedApplicationService which only describes js defined extensions of extends cds.ApplicationService, which I was thinking was cleaner/fits nicer into the overall model, but maybe isnt worth the extra (not undoable but more involved) refactoring
27 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #101
only adds to the
RemoteFlowSourcemodel, not the CDS modelling because that would have required a deeper (I think currently unnecessary) addition to the concept of service definition