Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fix Replace in... unit tests#8117

Merged
njx merged 2 commits into
nj/replace-across-filesfrom
randy/replace-in-unit-tests
Jun 13, 2014
Merged

Fix Replace in... unit tests#8117
njx merged 2 commits into
nj/replace-across-filesfrom
randy/replace-in-unit-tests

Conversation

@redmunds
Copy link
Copy Markdown
Contributor

@redmunds redmunds commented Jun 13, 2014

This addresses this comment.

  1. In both tests, I forgot to pass the dirEntry as the first param to the openSearchBar() function.
  2. After doing that, I discovered that that the path was wrong
  3. In the second test, should have created a fileEntry.

cc @njx

@redmunds redmunds mentioned this pull request Jun 13, 2014
Merged
@njx
Copy link
Copy Markdown

njx commented Jun 13, 2014

Looks good, merging.

njx pushed a commit that referenced this pull request Jun 13, 2014
Merge pull request #8117 from adobe/randy/replace-in-unit-tests
e859c2f 
Fix Replace in... unit tests
@njx njx merged commit e859c2f into nj/replace-across-files Jun 13, 2014
@njx njx deleted the randy/replace-in-unit-tests branch June 13, 2014 02:03
@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@redmunds @njx