Collect Named CSS Region Flows#4890
Conversation
JeffryBooher
commented
Aug 23, 2013
- Adds a function to extract all named css region flow names.
…amed css region flows
There was a problem hiding this comment.
This function is actually always returning an array, even thought it can be empty. The ? doesn't seem to be required here.
|
@TomMalbran we only have to do @Private when an object is exported with private methods. In this case we aren't exporting the functions so @Private isn't required. The other "private" functions in this file also have JSDoc that doesn't start with @Private. |
|
Ok. So I am not sure if we are suing @Private always right then, the docs don't make it that clear either. |
There was a problem hiding this comment.
Nit: why one character indent for this line? Also extra space between "the" and "content."
|
Done with review. Only some minor nits. |
There was a problem hiding this comment.
Great! I was about to tell you to exclude "none" and "inherit". I'm not sure about others and reserved flow names.
Again, please use double-quotes for these strings.