Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Spanish strings for Sprint 26#4286

Merged
TomMalbran merged 4 commits into
masterfrom
jbalsas/spanish_sprint26
Jun 21, 2013
Merged

Spanish strings for Sprint 26#4286
TomMalbran merged 4 commits into
masterfrom
jbalsas/spanish_sprint26

Conversation

@jbalsas
Copy link
Copy Markdown
Contributor

@jbalsas jbalsas commented Jun 19, 2013

@jasonsanjose Sorry I didn't get this on time for the release :S
@TomMalbran Care to review? ;)

Comment thread src/nls/es/strings.js Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace {0] with {0}

I feel like something like La versión de este paquete es la misma... for the previous string and La versión {0} de este paquete es... for this strings, sounds closer to the English version.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will fix!

@TomMalbran
Copy link
Copy Markdown
Contributor

@jbalsas Thanks for updating the strings. I just added a few minor comments.

@ghost ghost assigned TomMalbran Jun 20, 2013
@julianasuh
Copy link
Copy Markdown
Contributor

Hi Tom, feel free to merge when ready @TomMalbran

@jbalsas
Copy link
Copy Markdown
Contributor Author

jbalsas commented Jun 20, 2013

@TomMalbran Changes fixed and pushed

@TomMalbran
Copy link
Copy Markdown
Contributor

@jbalsas Thanks for the changes. My pull request #3324 that had a very small string update on line 132 just landed. The UI freeze is actually tomorrow, so I will leave this open till then in case there is another string update like the one I mentioned.

@jbalsas
Copy link
Copy Markdown
Contributor Author

jbalsas commented Jun 21, 2013

@TomMalbran I've added one more commit with your command string suggestion and your last string fix. Should be good to go now ;)

@TomMalbran
Copy link
Copy Markdown
Contributor

Great. If you have time there is one more string missing LOCALE_HU on line 414. If not I could just add it and merge it.

@jbalsas
Copy link
Copy Markdown
Contributor Author

jbalsas commented Jun 21, 2013

@TomMalbran Added! It's already past my bedtime, so if you see something missing, feel free to fix and merge ;)

@TomMalbran
Copy link
Copy Markdown
Contributor

Thanks. Merging :)

TomMalbran added a commit that referenced this pull request Jun 21, 2013
@TomMalbran TomMalbran merged commit 73e2a41 into master Jun 21, 2013
@TomMalbran TomMalbran deleted the jbalsas/spanish_sprint26 branch June 21, 2013 22:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants