This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Switch js code hinting to be powered by tern. #3439
Merged
Merged
Changes from all commits
Commits
Show all changes
96 commits
Select commit
Hold shift + click to select a range
81ef26d
Add submodules for tern and acorn
832aaa2
prototyping hooking up ternjs to power codehints.
4369247
Update tern submodule to pick up recent bugfixes
cb4e0c6
Fix up tern completions - format changed slightly
3c874bf
Hook up multiple files for ternjs hinting.
9689288
Update to latest tern - at least one infinite loop fixed
d648572
Fix problem where hints are displayed before tern has finished comput…
dd63429
Update to latest tern - fixes a hang on some files
eztierney 46365a6
Find builtin .json files in new location.
eztierney f4bcdfc
case insensitive matches, middle matching, and use tern rawCompletion…
7361589
Merge remote-tracking branch 'upstream/tern-experiments' into tern-ex…
e4a1855
change tern query not to sort or filter the results
412dedf
Move tern server into a web-worker.
eztierney 8032353
use eztierney fork of tern.git
3d253d8
change tern submodule url from http:// to https://
f9bb81f
merge in changes from eztierney/brackets
25069f3
remove console.log
33579f6
roll back tern submodule to avoid hang
eztierney 7bfaedf
Use tern to sort ids by depth, remove scope info
97a977c
Merge pull request #2 from dloverin/more-tern
eztierney 7ac5459
fix bug where hints disappear on first character
a0ee374
fix bug where hints disappear after first key press
fcd7782
Merge pull request #3 from dloverin/more-tern
eztierney 98d05fd
Update to version of tern with bugfixes to avoid hang when requesting…
eztierney 4e6c8f5
Update to tern with getfile fixes
eztierney 9a21f42
Add license file for requirejs
eztierney 963474a
Merge branch 'master' into tern-experiments, to bring tern work up to…
eztierney d947130
Add alphabetical secondary sort when bringing prefix matches to the top
bf7404a
Add alphabetical secondary sort when bringing prefix matches to the top
01f6b2c
add browser.json to tern environment by default
9bf0b9f
fix bug where no hints would be provided after '('
8a6d29f
Merge pull request #4 from dloverin/more-tern
eztierney 0746864
Remove espirma and related scope info code
08f356c
Merge pull request #5 from dloverin/cleanup-esprima
eztierney 63c89f4
Add support for hinting function types.
eztierney 98e37b1
Merge branch 'master' into tern-experiments
eztierney c1f1e44
Update to latest tern and acorn
eztierney 7ed099f
Update submodule to latest tern
eztierney 6666bd7
Switch submodules to point to the real acorn and tern instead of my fork
eztierney c05e551
Merge branch 'tern-experiments' of https://github.com/eztierney/brack…
eztierney d371c0f
Fix JSHint warnings and exclude tern and acorn related files from grunt.
petetronic ee09d6a
Removing unnecessary exclude from grunt.
petetronic 3107c97
Merge pull request #1 from pfarland/js-code-intelligence
eztierney c887e87
new guessing
dac2002
Add guesses to code hints
9d56227
remove requestProperties
aab1d58
more grunt cleanup
eztierney ecfb080
Remove left over debugging code
eztierney d545327
fixes #2 and #4 - function type hinting
eztierney 7af5378
Merge pull request #9 from eztierney/iss-2-4
bef501f
Update to latest tern - fixes issue #3
eztierney af9a7f0
Added Goto Definition.
jeffkenton 7bb13ce
Code cleanup from Erik's review.
jeffkenton 42ad4f7
Cleanup grunt complaints.
jeffkenton 7d52361
Add StringUtils.htmlEscape() back in.
87de92d
Hook up initial requirejs support.
eztierney fdb8f5b
Merge pull request #16 from eztierney/js-code-intelligence
c097d19
log error for tern 'type' request
fa2bebc
Cleanup - mostly deleting unused code
eztierney 8131900
Some unit test cleanup
eztierney c3919ed
Fix timing problem.
eztierney ee2dd1d
Fix for issue when multiple requests were made
eztierney cf26938
Update to newest tern to pick up some bugfixes
eztierney 0bab9dc
Make Jump-To-Definition switch to new file when definition isn't loca…
jeffkenton 5faff1d
Merge pull request #22 from jeffkenton/js-code-intelligence
eztierney 40e1599
Remove tern and acorn from current location
eztierney 1c62677
Move tern and acorn submodules into thirdparty directory.
eztierney 5e11b5a
Updates to expected results.
eztierney 51edab6
Fix Jump-To-Definition bug: trying to open new file when search fails.
jeffkenton e46d260
Get all unit tests passing
eztierney 05e0640
Update tern to pick up a bugfix around Object properties
eztierney aeee6aa
If we can't find a file relative to the current dir, look relative to…
eztierney ec9a5af
Remember the resolved path we used with tern so that jump to definiti…
petetronic 2e357e6
Merge branch 'master' into js-code-intelligence
eztierney d7adb07
Fix merge snafu
eztierney aba25e2
use StringMatch class to sort hints
a2598a9
sort library globals below user globals
6f19820
Remove refreshOuterScope
ab0b372
Get hint value from 'label' property instead of 'value' property
3eee0be
use .value instead of .label to reduce confusion
d96d73d
cleanup jslint warnings
eztierney e0c551d
remove unused hinting for globals
77a1b7f
Grunt cleanup, and deleted more unused code
eztierney 9037188
Merge branch 'js-code-intelligence' into 'master'
eztierney e5e028e
remove pending requests and send message from tern-worker on Tern errors
20423c9
fix grunt warning
dbb7d3f
Merge branch 'js-code-intelligence' to pick up fix for Issue #30
eztierney 33a016d
Change for-in loop to Collections.forEach to satify JSLint (looks lik…
daa64a3
cleanup from code review
eztierney ebc6b64
Add some more unit tests
eztierney 0f43f54
remove CollectionsUtils.hasProperty inside of CollectionUtils.forEach
c5052f8
Add a couple of unit tests for jump to definition
eztierney 725a1e8
remove Collections.forEach loop
f6a073c
When typing, only automatically show hints for the "." character and …
5a2efdf
add jquery api to hints
7b31da7
fix problem where jQuery was not recognized as a builtin
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is obviously not a regression from current behavior, but I do wonder if this code is going to fail on valid identifiers. Ahh, I see. It does fail some in that if I have a variable called
façade, if I typefaçthe hinting stops until I hit thea. Anyhow, it's a minor point and nothing to fix now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, thats obviously not going to work.
I filed adobe-research#38 - we probably just want to ask the token if it is an identifier, since the token should have the correct info.