This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Partial fix for #2015 (Bottom panels get messed up if resized to max height)#2223
Merged
Conversation
…height). When panel size > the available area (which can happen several ways, including a bug in Resizer that allows drags to overshoot the max size that would fit), we were computing a negative size for the #editor-holder. This was a problem because jQuery no-ops on negative sizes; clipping to 0 gives much better results. #2015 should remain open to track the other panel-oversize-related bugs mentioned there.
Member
Author
Contributor
|
reviewing |
Contributor
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Nov 27, 2012
Partial fix for #2015 (Bottom panels get messed up if resized to max height)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #2015 -- fixes the originally reported bug, but not several related issues that are listed lower down in the bug thread.
About this fix:
When panel size > the available area (which can happen several ways, including a bug in Resizer that allows drags to overshoot the max size that would fit), we were computing a negative size for the #editor-holder. This was a problem because jQuery no-ops on negative sizes; clipping to 0 gives much better results.
#2015 should remain open to track the other panel-oversize-related bugs mentioned there.