This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix issue #1292 (Lots of menu-related console spam)#1294
Merged
Conversation
- Only warn on missing relativeID if 'position' requires a relativeID Other minor cleanups: - Add warning if relativeID is a section marker is but 'position' is not section-relative - Remove unused $sectionItems var - Add TODO about simpifying part of _getRelativeMenuItem()
Contributor
|
Looks good! Merging. But one comment: IIRC, we have a convention that any TODOs are filed as either bugs or features in the backlog. There are a number of TODOs in that file that don't have associated issues (including one added by this pull). Did we stop enforcing this? |
joelrbrandt
added a commit
that referenced
this pull request
Jul 23, 2012
Fix issue #1292 (Lots of menu-related console spam)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #1292 (Lots of menu-related console spam):
Other minor cleanups: