This repository was archived by the owner on Sep 6, 2021. It is now read-only.
fixes issues #1270 #1271 #1272, ESC key handling with popups#1276
Merged
Conversation
- fixed ESC key not working to dismiss dialogs by fixing bug where popup was removed from list when it was persistant - simplified addPopUp() API by removing different function call relating to popup persistance and instead having an "autoAddRemove" parameter - prefixed data keys with "PopUpManager" since PopUpManager is decorating elements it doesn't own - changed closing call for menus and context menus to call this.close() instead of closeAll()
Contributor
|
reviewing |
Contributor
There was a problem hiding this comment.
REMINDER: need to update new context menu unit test I added in pull request #1273 to uncomment line that checks for contextMenuClose event.
Contributor
Author
There was a problem hiding this comment.
Randy, I've pushed my changes so you can update test in the pull request?
Contributor
|
done with initial review |
- removed _removePopup() function since complexity of having this helper function isn't worth the savings of reusing the "index" var. I don't except their to be many visible popups at one time, so computing the index more than once isn't costly
Contributor
|
Looks good |
This was referenced Aug 11, 2020
This was referenced Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issues #1270 #1271 #1272