Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Resolve loadStyleSheet with the created link element#1093

Merged
redmunds merged 2 commits into
masterfrom
jason-sanjose/loadstylesheet
Jun 21, 2012
Merged

Resolve loadStyleSheet with the created link element#1093
redmunds merged 2 commits into
masterfrom
jason-sanjose/loadstylesheet

Conversation

@jasonsanjose
Copy link
Copy Markdown
Member

Allows extensions to manipulate or remove the created style sheet. Also, flattened some style hierarchy for the inline editor related rules list.

@ghost ghost assigned redmunds Jun 21, 2012
@redmunds
Copy link
Copy Markdown
Contributor

reviewing

Comment thread src/styles/brackets.less Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you removed the extra line at the end of the file. It should work ok, but I am curious why?

I find editing easier with an extra empty line, and I have run into very rare cases where it did cause a problem, so I always make a point of having an extra line at the end of each file.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inadvertent. Fixed.

@redmunds
Copy link
Copy Markdown
Contributor

initial review complete

@jasonsanjose
Copy link
Copy Markdown
Member Author

@redmunds Pushed fix.

redmunds added a commit that referenced this pull request Jun 21, 2012
Resolve loadStyleSheet with the created link element
@redmunds redmunds merged commit 796f112 into master Jun 21, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants