Double-clicking in file tree may randomly select an unrelated file/folder.

[RaymondLim]

1. Use Brackets src folder as your project root.
2. Make sure that you have expanded several nested levels of folders. e.g. nls folder that has a long list of subfolders.
3. Open two or more files in the top view by double-clicking on them in the file tree. It will be easier to reproduce if you open the same files used in the screnshot since you will have to expand several levels deep folder and have to scroll in the sidebar.
4. In the file tree (not working set), double-click on closebrackets.js again so that it is selected in the Top working set view.
5. Important! Click inside the bottom view. If you skip this step, then you won't be able to reproduce the issue.
6. Scroll up in the file tree until you see languages.json file and double-click on it. You may notice that as soon as the first click is done, the file tree may scroll a little bit when selection highlight jumps to the working set (or the focus is set to the top view).

Result: You will see an incorrect selection in the file tree instead of the selection on languages.json in Top working set view as in the screenshot.

[dangoor]

I just tried to reproduce this in master but was unable to do so. I'm not sure if this would reproduce in the ProjectManager branch (which is what I was really out to test).

[JeffryBooher]

@RaymondLim I'm unable to reproduce this on the latest master. I think it's a duplicate of #9032 which was fixed already #9160

[RaymondLim]

@JeffryBooher I know it's not easy to reproduce it on Windows, but I'm afraid this may be introduced by #9160 rather than fixed by it. This is why I left a note in 9032.

Sometimes, an incorrect file gets opened in the Top view and not just the incorrect highlight in the file tree. I'll try to take a screenshot of it later when I can reproduce it.

[JeffryBooher]

@RaymondLim you bisected and it points to #9160?

[RaymondLim]

Instead of highlightling languages.json file, my double-click in file tree just open main.js.

[JeffryBooher]

I followed your steps on the Mac and this is what I get:

[RaymondLim]

@JeffryBooher I think the issue has to do with the way jstree handles the single click and double click. I can reproduce the incorrect selection with double click in a version before your pr #9160. So this is an issue not yet covered by your fix in #9160 and not really introduced by your changes.

The first click of the double click re-selects the already opened languages.json file and sets the focus in the Top view. So before the second click of the double click is interpreted as a double click, the file tree gets scrolled and the second click acts on the wrong file.

[RaymondLim]

@JeffryBooher You need to expand more folders as I have in my screenshot to see the issue.

[JeffryBooher]

Maybe it's fixed with @dangoor's new file tree? I have folders above it expanded. There are lots of folders scrolled out of view. Maybe try with kevin's tree?

[RaymondLim]

@JeffryBooher & @dangoor Just tried in ProjectManager branch and I still can reproduce it.

[JeffryBooher]

I just reproduced this following the standup and @RaymondLim demonstrating it. The Window has to be a certain size to repro. Also I can no longer reproduce it. Might want to see when the file tree scrolls something into view. It looked like it was scrolling the item to the middle of the screen.

[JeffryBooher]

@RaymondLim can you reproduce this on the latest master? This seems something in the file tree is scrolling the item into view which has probably changed.