Find in Files 'selected match' highlight shown on wrong match after editing text

[peterflynn]

1. Do a Find in Files on a string that appears several times in one file
2. Click the 2nd result
3. Go to the top of the file and type in another match by hand (or copy/paste, or duplicate the line the 1st result is on, etc. -- anything that creates a new match earlier in the file)

Result: The 'selected match' highlight is now on (what used to be) the 1st result.

Expected: Highlight remains on the match you last clicked, (what used to be) the 2nd result.

If you delete an existing result instead in step 3, the highlight will be wrong in the opposite direction instead.

This is happening because the code that re-renders the results list after an edit just restores the selection highlight by table-row index.

Since this isn't a very important selection -- it's really just a marker for 'last clicked match' -- I suggest we just clear it whenever the number of matches has changed, rather than trying to do something fancy to restore it more correctly.

Note: This occurs on master, so it is not a result of the Replace In Files code changes.

[TomMalbran]

When I did that code, I was just trying to select the closest possible match, but it can be really hard without doing more analysis of the changes.

I agree that is just better to not highlight the results rows, but instead of just clearing the highlight, I suggest to highlight the current file in the list. This is so that you can later easily see where you are in the results. It is why I wanted the lines to get highlighted, since you can easily get lots in so many results.